Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 316983002: Unflake a test. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Unflake a test. BUG=https://code.google.com/p/dart/issues/detail?id=19052 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
I can't repro this locally on my Mac even if I run 20 copies of ...
6 years, 6 months ago (2014-06-04 17:05:00 UTC) #1
nweiz
lgtm I don't think this would tickle that particular race condition.
6 years, 6 months ago (2014-06-04 19:29:36 UTC) #2
Bob Nystrom
6 years, 6 months ago (2014-06-04 20:30:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698