Issue 316813006: Fix previous fix, by still making 'handle' the socket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316813006: Fix previous fix, by still making 'handle' the socket. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen

Modified:
6 years, 6 months ago

Reviewers:
Søren Gjesse, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix previous fix, by still making 'handle' the socket. BUG= Committed: https://code.google.com/p/dart/source/detail?r=36999

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -19 lines)			Patch
	M	runtime/bin/eventhandler_win.h	View		2 chunks	+3 lines, -6 lines	0 comments	Download
	M	runtime/bin/eventhandler_win.cc	View		4 chunks	+3 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

TBR. I'll revert the entire stack, if this does not fly.

6 years, 6 months ago (2014-06-04 15:56:15 UTC) #1

Anders Johnsen

Committed patchset #1 manually as r36999 (presubmit successful).

6 years, 6 months ago (2014-06-04 15:57:01 UTC) #2

kasperl

6 years, 6 months ago (2014-06-04 16:54:50 UTC) #3

Message was sent while issue was closed.

LGTM even though the double book keeping is a bit messy. Let's chat about
cleaner alternatives tomorrow. Thanks for fixing the broken build though :-)

Expand Messages | Collapse Messages