Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 316253003: Scanner cleanups: use isolates to allocate handles and zone objects (Closed)

Created:
6 years, 6 months ago by srdjan
Modified:
6 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Scanner cleanups: use isolates to allocate handles and zone objects; remove C-heap allocation of structs. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=37053

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -35 lines) Patch
M runtime/vm/scanner.h View 2 chunks +3 lines, -7 lines 0 comments Download
M runtime/vm/scanner.cc View 1 10 chunks +39 lines, -28 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
6 years, 6 months ago (2014-06-05 21:49:22 UTC) #1
hausner
LGTM with one rant. https://codereview.chromium.org/316253003/diff/20001/runtime/vm/scanner.cc File runtime/vm/scanner.cc (right): https://codereview.chromium.org/316253003/diff/20001/runtime/vm/scanner.cc#newcode42 runtime/vm/scanner.cc:42: private: IMO it does not ...
6 years, 6 months ago (2014-06-05 21:58:54 UTC) #2
srdjan
https://codereview.chromium.org/316253003/diff/20001/runtime/vm/scanner.cc File runtime/vm/scanner.cc (right): https://codereview.chromium.org/316253003/diff/20001/runtime/vm/scanner.cc#newcode42 runtime/vm/scanner.cc:42: private: On 2014/06/05 21:58:54, hausner wrote: > IMO it ...
6 years, 6 months ago (2014-06-05 22:03:51 UTC) #3
srdjan
6 years, 6 months ago (2014-06-05 22:04:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698