Issue 315953002: Give the watchers more time to detect changes, in physical_resource_provider_test.

Issue 315953002: Give the watchers more time to detect changes, in physical_resource_provider_test. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen

Modified:
6 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Give the watchers more time to detect changes, in physical_resource_provider_test. BUG= R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=36990

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	pkg/analysis_server/test/physical_resource_provider_test.dart	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/315953002/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart File pkg/analysis_server/test/physical_resource_provider_test.dart (right): https://codereview.chromium.org/315953002/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart#newcode41 pkg/analysis_server/test/physical_resource_provider_test.dart:41: // because on MacOS, file modifications that occur ...

6 years, 6 months ago (2014-06-04 11:05:06 UTC) #2

Anders Johnsen

https://codereview.chromium.org/315953002/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart File pkg/analysis_server/test/physical_resource_provider_test.dart (right): https://codereview.chromium.org/315953002/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart#newcode41 pkg/analysis_server/test/physical_resource_provider_test.dart:41: // because on MacOS, file modifications that occur just ...

6 years, 6 months ago (2014-06-04 11:09:23 UTC) #3

Anders Johnsen

6 years, 6 months ago (2014-06-04 11:09:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36990 (presubmit successful).

Expand Messages | Collapse Messages