Packages for Try Dart and dart2js.

Packages for Try Dart and dart2js.

package:compiler and package:try.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37437

[ahe, 2014-06-04 11:29:58]

https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp
File dart/pkg/pkg.gyp (right):

https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp#newcode23
dart/pkg/pkg.gyp:23: '../sdk/lib/_internal/libraries.dart',
Johnni, this might not work on Windows, could you try patching it in?

[Johnni Winther, 2014-06-10 08:38:34]

https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp
File dart/pkg/pkg.gyp (right):

https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp#newcode23
dart/pkg/pkg.gyp:23: '../sdk/lib/_internal/libraries.dart',
On 2014/06/04 11:29:58, ahe wrote:
> Johnni, this might not work on Windows, could you try patching it in?

Patched in and built. Is there a way to verify that it's working?

[ahe, 2014-06-10 23:17:11]

Thank you, Johnni!

https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp
File dart/pkg/pkg.gyp (right):

https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp#newcode23
dart/pkg/pkg.gyp:23: '../sdk/lib/_internal/libraries.dart',
On 2014/06/10 08:38:34, Johnni Winther wrote:
> On 2014/06/04 11:29:58, ahe wrote:
> > Johnni, this might not work on Windows, could you try patching it in?
> 
> Patched in and built. Is there a way to verify that it's working?

I think the simplest way is:

1. Make sure to run "gclient runhooks" to regenerate project files.

2. python tools/build.py -mrelease packages

3. Use the packages: sdk\bin\dart2js.bat --analyze-only
-pbuild/ReleaseIA32/packages/ site/try/src/leap.dart

[Johnni Winther, 2014-06-11 08:21:56]

On 2014/06/10 23:17:11, ahe wrote:
> Thank you, Johnni!
> 
> https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp
> File dart/pkg/pkg.gyp (right):
> 
> https://codereview.chromium.org/315943003/diff/1/dart/pkg/pkg.gyp#newcode23
> dart/pkg/pkg.gyp:23: '../sdk/lib/_internal/libraries.dart',
> On 2014/06/10 08:38:34, Johnni Winther wrote:
> > On 2014/06/04 11:29:58, ahe wrote:
> > > Johnni, this might not work on Windows, could you try patching it in?
> > 
> > Patched in and built. Is there a way to verify that it's working?
> 
> I think the simplest way is:
> 
> 1. Make sure to run "gclient runhooks" to regenerate project files.
> 
> 2. python tools/build.py -mrelease packages
> 
> 3. Use the packages: sdk\bin\dart2js.bat --analyze-only
> -pbuild/ReleaseIA32/packages/ site/try/src/leap.dart

Problems with libraries.dart:

d:\dart-repo\dart>sdk\bin\dart2js.bat --analyze-only
-pbuild/ReleaseIA32/packages/ site/try/src/leap.dart
build/ReleaseIA32/packages/compiler/implementation/apiimpl.dart:13:8:
Error: Can't read 'package:libraries.dart' (Error reading
'build/ReleaseIA32/packages/libraries.dart' (OS Error: Access is denied.
, errno = 5)).
import '../../libraries.dart';
       ^^^^^^^^^^^^^^^^^^^^^^
site/try/src/ui.dart:91:15:
Warning: No operator '[]' in class 'ElementList'.
  String id = select.querySelectorAll('option')[select.selectedIndex].id;
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[ahe, 2014-06-11 19:09:19]

How about now?

[ahe, 2014-06-11 20:23:39]

Johnni, thank you for your help testing this. Turns out I was sitting right in
front of Bob's windows machine so I've been able to test it there. So you don't
need to do anything. Well, besides reviewing the code.

[ricow1, 2014-06-12 06:30:53]

https://codereview.chromium.org/315943003/diff/20001/dart/pkg/pkg.gyp
File dart/pkg/pkg.gyp (right):

https://codereview.chromium.org/315943003/diff/20001/dart/pkg/pkg.gyp#newcode22
dart/pkg/pkg.gyp:22: '../sdk/lib/_internal/compiler',
Don't you need to explicitly depend on the files (+below for site/try)?
If you do that could give a lot extra files and mess up mac compilation (there
are issues if you have to many input files. One solution here is to add a
dependency on utils/compiler/compiler.gyp:dart2js_files_stamp and add 
'<(SHARED_INTERMEDIATE_DIR)/dart2js_files.stamp' to inputs

could you explain (and maybe even add a comment here) about why we need to
depend on this here.

[ahe, 2014-06-12 07:27:53]

https://codereview.chromium.org/315943003/diff/20001/dart/pkg/pkg.gyp
File dart/pkg/pkg.gyp (right):

https://codereview.chromium.org/315943003/diff/20001/dart/pkg/pkg.gyp#newcode22
dart/pkg/pkg.gyp:22: '../sdk/lib/_internal/compiler',
On 2014/06/12 06:30:52, ricow1 wrote:
> Don't you need to explicitly depend on the files (+below for site/try)?
> If you do that could give a lot extra files and mess up mac compilation (there
> are issues if you have to many input files. One solution here is to add a
> dependency on utils/compiler/compiler.gyp:dart2js_files_stamp and add 
> '<(SHARED_INTERMEDIATE_DIR)/dart2js_files.stamp' to inputs
> 
> could you explain (and maybe even add a comment here) about why we need to
> depend on this here.

I only copy files in the list. Directories are symlinked. Does that answer your
question?

[ricow1, 2014-06-12 07:35:53]

lgtm

https://codereview.chromium.org/315943003/diff/20001/dart/pkg/pkg.gyp
File dart/pkg/pkg.gyp (right):

https://codereview.chromium.org/315943003/diff/20001/dart/pkg/pkg.gyp#newcode22
dart/pkg/pkg.gyp:22: '../sdk/lib/_internal/compiler',
On 2014/06/12 07:27:53, ahe wrote:
> On 2014/06/12 06:30:52, ricow1 wrote:
> > Don't you need to explicitly depend on the files (+below for site/try)?
> > If you do that could give a lot extra files and mess up mac compilation
(there
> > are issues if you have to many input files. One solution here is to add a
> > dependency on utils/compiler/compiler.gyp:dart2js_files_stamp and add 
> > '<(SHARED_INTERMEDIATE_DIR)/dart2js_files.stamp' to inputs
> > 
> > could you explain (and maybe even add a comment here) about why we need to
> > depend on this here.
> 
> I only copy files in the list. Directories are symlinked. Does that answer
your
> question?

Ah, yes, so you need the changes because we need libraries.dart, thanks for the
explanation

[ahe, 2014-06-18 06:43:20]

Committed patchset #3 manually as r37437 (presubmit successful).