Issue 315843002: Add main() to analysis_abstract_test.dart to fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315843002: Add main() to analysis_abstract_test.dart to fix build. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add main() to analysis_abstract_test.dart to fix build. Maybe we should drop _test prefix from it. TBR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36969

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	pkg/analysis_server/test/analysis_abstract_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r36969 (presubmit successful).

6 years, 6 months ago (2014-06-04 02:08:09 UTC) #2

Brian Wilkerson

LGTM, but I think you're right, the better solution would be to rename the file ...

6 years, 6 months ago (2014-06-04 13:15:47 UTC) #3

scheglov

6 years, 6 months ago (2014-06-04 14:30:13 UTC) #4

Message was sent while issue was closed.

On 2014/06/04 13:15:47, Brian Wilkerson wrote:
> LGTM, but I think you're right, the better solution would be to rename the
file
> because it isn't intended to be used as a test.

https://codereview.chromium.org/313913002

Expand Messages | Collapse Messages