Issue 315303002: Improve scanner performance by remembering string's CharAt function as the string type does not cha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315303002: Improve scanner performance by remembering string's CharAt function as the string type does not cha… (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve scanner performance by remembering string's CharAt function as the string type does not change during scanner's lifetime. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=37052

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -10 lines)			Patch
M	runtime/vm/object.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download
M	runtime/vm/scanner.h	View	1 2 3	4 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/scanner.cc	View	1 2 3	6 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/315303002/diff/40001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/315303002/diff/40001/runtime/vm/object.cc#newcode16004 runtime/vm/object.cc:16004: NoGCScope no_gc; What is the reason for the ...

6 years, 6 months ago (2014-06-05 20:49:46 UTC) #2

srdjan

Committed patchset #4 manually as r37052 (presubmit successful).

6 years, 6 months ago (2014-06-05 21:06:29 UTC) #3

srdjan

6 years, 6 months ago (2014-06-05 21:16:39 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/315303002/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/315303002/diff/40001/runtime/vm/object.cc#new...
runtime/vm/object.cc:16004: NoGCScope no_gc;
On 2014/06/05 20:49:46, zra wrote:
> What is the reason for the NoGCScope?

Copy and paste error: removed.

Expand Messages | Collapse Messages