Issue 315063002: Display timeout errors more gracefully.

Issue 315063002: Display timeout errors more gracefully. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom

Modified:
6 years, 6 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Display timeout errors more gracefully. This ensures they don’t show up as unexpected errors, and produces a nicer error message than the one from dart:io. BUG=https://code.google.com/p/dart/issues/detail?id=18828, https://code.google.com/p/dart/issues/detail?id=15380 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37010

Patch Set 1 #

Patch Set 2 : Show "please try again" on timeouts from known URLs. #

Total comments: 4

Patch Set 3 : Revise. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -26 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/http.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/io.dart	View	1 2	1 chunk	+21 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/progress.dart	View		2 chunks	+2 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/hosted.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	1 2	3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm Don't forget that another part of issue 15380 is providing better errors for the ...

6 years, 6 months ago (2014-06-04 19:36:59 UTC) #2

Bob Nystrom

Committed patchset #3 manually as r37010 (presubmit successful).

6 years, 6 months ago (2014-06-04 20:34:44 UTC) #3

Bob Nystrom

https://codereview.chromium.org/315063002/diff/20001/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/315063002/diff/20001/sdk/lib/_internal/pub/lib/src/io.dart#newcode642 sdk/lib/_internal/pub/lib/src/io.dart:642: /// [input]. On 2014/06/04 19:37:00, nweiz wrote: > Document ...

6 years, 6 months ago (2014-06-04 20:35:06 UTC) #4

Bob Nystrom

6 years, 6 months ago (2014-06-04 20:35:18 UTC) #5

Message was sent while issue was closed.

On 2014/06/04 20:35:06, Bob Nystrom wrote:
>
https://codereview.chromium.org/315063002/diff/20001/sdk/lib/_internal/pub/li...
> File sdk/lib/_internal/pub/lib/src/io.dart (right):
> 
>
https://codereview.chromium.org/315063002/diff/20001/sdk/lib/_internal/pub/li...
> sdk/lib/_internal/pub/lib/src/io.dart:642: /// [input].
> On 2014/06/04 19:37:00, nweiz wrote:
> > Document [url].
> 
> Done.
> 
>
https://codereview.chromium.org/315063002/diff/20001/sdk/lib/_internal/pub/li...
> File sdk/lib/_internal/pub/lib/src/utils.dart (right):
> 
>
https://codereview.chromium.org/315063002/diff/20001/sdk/lib/_internal/pub/li...
> sdk/lib/_internal/pub/lib/src/utils.dart:629: }
> On 2014/06/04 19:37:00, nweiz wrote:
> > Nit: I'd use ?: here to condense these four lines into one.
> 
> Done.

I'll slap together another patch for 500 errors.

Expand Messages | Collapse Messages