Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 315053005: Split computers.dart and use parsed JSON objects for navigation tests. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Split computers.dart and use parsed JSON objects for navigation tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37007

Patch Set 1 #

Patch Set 2 : Rollback debug output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -940 lines) Patch
A + pkg/analysis_server/lib/src/computer/computer_highlights.dart View 2 chunks +1 line, -200 lines 0 comments Download
A pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +208 lines, -0 lines 0 comments Download
D pkg/analysis_server/lib/src/computers.dart View 1 chunk +0 lines, -716 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 5 chunks +45 lines, -22 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-06-04 18:46:15 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-04 19:30:32 UTC) #2
scheglov
6 years, 6 months ago (2014-06-04 20:20:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698