Fix double-closing of handles in Windows EventHandler.

Fix double-closing of handles in Windows EventHandler.

BUG=
R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36991

[kasperl, 2014-06-04 11:37:54]

Make handle_ == INVALID represent the actually closed state?

https://codereview.chromium.org/315003002/diff/20001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/315003002/diff/20001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.cc:393: 
Extra newline here.

https://codereview.chromium.org/315003002/diff/20001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.cc:436: // Close handle, but don't mark as closed_.
closed_ -> closed.

[Anders Johnsen, 2014-06-04 11:50:37]

PTAL

[kasperl, 2014-06-04 11:52:02]

LGTM with a small nit:

https://codereview.chromium.org/315003002/diff/40001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/315003002/diff/40001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.cc:182: ASSERT(IsHandleClosed());
Move the assert out of the !IsClosing check?

[Anders Johnsen, 2014-06-04 11:53:17]

https://codereview.chromium.org/315003002/diff/40001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/315003002/diff/40001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.cc:182: ASSERT(IsHandleClosed());
On 2014/06/04 11:52:01, kasperl wrote:
> Move the assert out of the !IsClosing check?

Done.

[Anders Johnsen, 2014-06-04 11:54:16]

Committed patchset #4 manually as r36991 (presubmit successful).

[Søren Gjesse, 2014-06-04 12:15:28]

lgtm