Navigation computer and two variants of tests for it.

Navigation computer and two variants of tests for it.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36958

[Brian Wilkerson, 2014-06-03 22:04:47]

LGTM, but it seems like I'm seeing a lot of duplicated code. We should think
about ways to share the code.

https://codereview.chromium.org/314493002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right):

https://codereview.chromium.org/314493002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/operation/operation_analysis.dart:75: //
TODO(scheglov) only is subscribed
Can we do this now, or is there a reason to wait?

  if (server.hasAnalysisSubscription(AnalysisService.NAVIGATION, file)) {

[scheglov, 2014-06-03 22:55:14]

On 2014/06/03 22:04:47, Brian Wilkerson wrote:
> LGTM, but it seems like I'm seeing a lot of duplicated code. We should think
> about ways to share the code.

Yes, there IS a lot of duplicated code.
Basically there are two sets of tests - first is done using function and
helpers; and second - using class members.
I hoped that we could compare them.


> 
>
https://codereview.chromium.org/314493002/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right):
> 
>
https://codereview.chromium.org/314493002/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/operation/operation_analysis.dart:75: //
> TODO(scheglov) only is subscribed
> Can we do this now, or is there a reason to wait?
> 
>   if (server.hasAnalysisSubscription(AnalysisService.NAVIGATION, file)) {

Will do.

[scheglov, 2014-06-03 23:14:54]

Committed patchset #2 manually as r36958 (presubmit successful).