Disable GZIP in pub serve’s HTTP server.

Disable GZIP in pub serve’s HTTP server.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36908

[nweiz, 2014-06-02 23:20:21]

Assuming you've verified that this does actually disable gzip, lgtm

[Bob Nystrom, 2014-06-02 23:50:19]

Committed patchset #1 manually as r36908 (presubmit successful).

[Bob Nystrom, 2014-06-02 23:51:31]

On 2014/06/02 23:20:21, nweiz wrote:
> Assuming you've verified that this does actually disable gzip, lgtm

I verified it makes a speed improvement (about 5% on the startup of pub serve on
todomvc). Presumably it's doing *something*. :)

[Anders Johnsen, 2014-06-03 07:08:49]

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/base_server.dart (right):

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/base_server.dart:132: // TODO(rnystrom):
Remove this when #5187 is fixed and we don't have to use
Due to the fact that barback is always run localhost->localhost, and never in a
production environment, I would argue that it never should use gzip, even when
the above issue is fixed.

[Anders Johnsen, 2014-06-03 07:09:01]

Oh, and lgtm :)

[nweiz, 2014-06-03 18:07:32]

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/base_server.dart (right):

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/base_server.dart:132: // TODO(rnystrom):
Remove this when #5187 is fixed and we don't have to use
On 2014/06/03 07:08:49, Anders Johnsen wrote:
> Due to the fact that barback is always run localhost->localhost, and never in
a
> production environment, I would argue that it never should use gzip, even when
> the above issue is fixed.

When the above issue is fixed, we won't be using HTTP at all.

[Anders Johnsen, 2014-06-03 18:37:18]

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/base_server.dart (right):

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/base_server.dart:132: // TODO(rnystrom):
Remove this when #5187 is fixed and we don't have to use
On 2014/06/03 18:07:32, nweiz wrote:
> On 2014/06/03 07:08:49, Anders Johnsen wrote:
> > Due to the fact that barback is always run localhost->localhost, and never
in
> a
> > production environment, I would argue that it never should use gzip, even
when
> > the above issue is fixed.
> 
> When the above issue is fixed, we won't be using HTTP at all.

You will still serve http content to the browser, right?

[nweiz, 2014-06-03 19:07:33]

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/base_server.dart (right):

https://codereview.chromium.org/314443003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/base_server.dart:132: // TODO(rnystrom):
Remove this when #5187 is fixed and we don't have to use
On 2014/06/03 18:37:18, Anders Johnsen wrote:
> On 2014/06/03 18:07:32, nweiz wrote:
> > On 2014/06/03 07:08:49, Anders Johnsen wrote:
> > > Due to the fact that barback is always run localhost->localhost, and never
> in
> > a
> > > production environment, I would argue that it never should use gzip, even
> when
> > > the above issue is fixed.
> > 
> > When the above issue is fixed, we won't be using HTTP at all.
> 
> You will still serve http content to the browser, right?

Ah, good point, you're probably right that that should continue to be
un-gzipped.