Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 314383002: - Report CodeSize instead of runtime for benchmarks reporting snapshot sizes. (Closed)

Created:
6 years, 6 months ago by Ivan Posva
Modified:
6 years, 6 months ago
Reviewers:
ricow1, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Report CodeSize instead of runtime for benchmarks reporting snapshot sizes. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M runtime/bin/run_vm_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/benchmark_test.h View 5 chunks +10 lines, -3 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
6 years, 6 months ago (2014-06-06 18:08:21 UTC) #1
siva
lgtm
6 years, 6 months ago (2014-06-06 18:20:05 UTC) #2
Ivan Posva
6 years, 6 months ago (2014-06-10 05:21:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37156 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698