Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 31423002: fix Polymer to work with latest JS interop (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix Polymer to work with latest JS interop both places we used dart:js were broken for different reasons :). On the bright side, a huge hacky workaround is gone! R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=28915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 2 months ago (2013-10-21 01:36:43 UTC) #1
Jacob
lgtm
7 years, 2 months ago (2013-10-21 01:37:52 UTC) #2
Jennifer Messerly
7 years, 2 months ago (2013-10-21 01:38:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698