Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 314173003: Clean ups for warnings and unused code. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean ups for warnings and unused code. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -72 lines) Patch
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 2 chunks +50 lines, -53 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-06-05 17:12:49 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-05 17:29:07 UTC) #2
scheglov
6 years, 6 months ago (2014-06-05 17:52:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698