Issue 313393003: Changes to improve the performance of reading a snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313393003: Changes to improve the performance of reading a snapshot. (Closed)

Created:
6 years, 6 months ago by zra

Modified:
6 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changes to improve the performance of reading a snapshot. There are two changes: 1. The decoding loop in ReadStream is unrolled. 2. Small reorganizaiton of PageSpace::TryAllocate to avoid copying SpaceUsuage structs around. These changes improve performance of CorelibIsolateStartup ~10-12% on ia32. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37141

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -6 lines)			Patch
	M	runtime/vm/datastream.h	View		6 chunks	+172 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

We should split this CL into pieces. The reader part LGTM. -Ivan https://codereview.chromium.org/313393003/diff/20001/runtime/vm/snapshot.h File runtime/vm/snapshot.h ...

6 years, 6 months ago (2014-06-09 20:48:20 UTC) #2

zra

Reduced change to the loop unrolling in the Reader. https://codereview.chromium.org/313393003/diff/20001/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/313393003/diff/20001/runtime/vm/snapshot.h#newcode179 runtime/vm/snapshot.h:179: ...

6 years, 6 months ago (2014-06-09 22:02:43 UTC) #3

zra

6 years, 6 months ago (2014-06-09 22:16:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r37141 (presubmit successful).

Expand Messages | Collapse Messages