Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 313353003: Clean up the Windows watcher. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -44 lines) Patch
M pkg/analysis_server/test/physical_resource_provider_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/watcher/lib/src/directory_watcher/windows.dart View 7 chunks +20 lines, -30 lines 0 comments Download
M pkg/watcher/test/directory_watcher/shared.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/watcher/test/directory_watcher/windows_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 6 months ago (2014-06-09 10:26:29 UTC) #1
Bob Nystrom
Perfect, thanks! LGTM!
6 years, 6 months ago (2014-06-09 19:52:16 UTC) #2
Anders Johnsen
6 years, 6 months ago (2014-06-10 06:48:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698