Don't use same value for socket() and handle(), as they are different concepts.

Don't use same value for socket() and handle(), as they are different concepts.

BUG=
R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36995

[kasperl, 2014-06-04 14:01:05]

https://codereview.chromium.org/313083004/diff/1/runtime/bin/eventhandler_win.cc
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/313083004/diff/1/runtime/bin/eventhandler_win...
runtime/bin/eventhandler_win.cc:436: completion_port_ =
CreateIoCompletionPort(reinterpret_cast<HANDLE>(socket()),
Would it make sense to have a non-virtual DoCreateCompletionPort that takes two
handles (the completion port and the socket/handle) so you can share the code?

[Anders Johnsen, 2014-06-04 14:05:21]

PTAL

https://codereview.chromium.org/313083004/diff/1/runtime/bin/eventhandler_win.cc
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/313083004/diff/1/runtime/bin/eventhandler_win...
runtime/bin/eventhandler_win.cc:436: completion_port_ =
CreateIoCompletionPort(reinterpret_cast<HANDLE>(socket()),
On 2014/06/04 14:01:05, kasperl wrote:
> Would it make sense to have a non-virtual DoCreateCompletionPort that takes
two
> handles (the completion port and the socket/handle) so you can share the code?

Done.

[kasperl, 2014-06-04 14:09:19]

LGTM.

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.cc:441: return DoCreateCompletionPort(
I'd pull the handle out into a local variable, but that's just how I roll.

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.h (right):

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.h:367: bool CreateCompletionPort(HANDLE
completion_port);
Maybe also mark this virtual? (like it's done with HandleIssueError).

[Anders Johnsen, 2014-06-04 14:16:31]

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.cc:441: return DoCreateCompletionPort(
On 2014/06/04 14:09:19, kasperl wrote:
> I'd pull the handle out into a local variable, but that's just how I roll.

Done.

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_win.h (right):

https://codereview.chromium.org/313083004/diff/20001/runtime/bin/eventhandler...
runtime/bin/eventhandler_win.h:367: bool CreateCompletionPort(HANDLE
completion_port);
On 2014/06/04 14:09:19, kasperl wrote:
> Maybe also mark this virtual? (like it's done with HandleIssueError).

Done.

[Anders Johnsen, 2014-06-04 14:17:08]

Committed patchset #3 manually as r36995 (presubmit successful).