Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 312733002: Return dart:html scroll* etc types to int (Closed)

Created:
6 years, 6 months ago by Leaf
Modified:
6 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Return dart:html scroll* etc types to int BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=36915

Patch Set 1 #

Total comments: 2

Patch Set 2 : JS return type is num #

Patch Set 3 : SDK regen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 1 chunk +28 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Leaf
6 years, 6 months ago (2014-06-03 10:45:22 UTC) #1
vsm
lgtm https://codereview.chromium.org/312733002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/312733002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode1331 tools/dom/templates/html/impl/impl_Element.darttemplate:1331: int get offsetHeight => JS('int', '#.offsetHeight', this).round(); The ...
6 years, 6 months ago (2014-06-03 10:50:44 UTC) #2
Leaf
https://codereview.chromium.org/312733002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/312733002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode1331 tools/dom/templates/html/impl/impl_Element.darttemplate:1331: int get offsetHeight => JS('int', '#.offsetHeight', this).round(); On 2014/06/03 ...
6 years, 6 months ago (2014-06-03 11:01:42 UTC) #3
Leaf
6 years, 6 months ago (2014-06-03 11:03:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r36915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698