Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 312653004: Use a proper closure instead of a 'close your eyes' style closure (Closed)

Created:
6 years, 6 months ago by siva
Modified:
6 years, 6 months ago
Reviewers:
vsm, rmacnak
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Use a proper closure instead of a 'close your eyes' style closure for setting up '_printClosure'. This avoid the startup cost of looking up types 'window', 'console' and 'HTMLDocument' types when we try to setup _printClosure. On a nexus 4 device the change results in the following time changes: Before the change: I/Dartium (25903): createIsolate before printClosure setting 155.318 ms I/Dartium (25903): createIsolate after printClosure setting 403.052 ms After the Change: I/Dartium (26537): createIsolate before printClosure setting 157.058 ms I/Dartium (26537): createIsolate after printClosure setting 162.918 ms R=rmacnak@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=36943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/html_native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
6 years, 6 months ago (2014-06-03 18:55:15 UTC) #1
vsm
lgtm! Nice - I think we're still looking up HTMLDocument though. I believe we're creating ...
6 years, 6 months ago (2014-06-03 19:12:21 UTC) #2
siva
Yes, I will look at the persistent handle creation for HTMLDocument to see if that ...
6 years, 6 months ago (2014-06-03 20:00:02 UTC) #3
rmacnak
lgtm
6 years, 6 months ago (2014-06-03 20:00:32 UTC) #4
siva
6 years, 6 months ago (2014-06-03 21:09:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r36943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698