Issue 312523007: Fix URL/native path conversions in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 312523007: Fix URL/native path conversions in pub. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix URL/native path conversions in pub. R=rnystrom@google.com BUG=19114 Committed: https://code.google.com/p/dart/source/detail?r=36906

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -21 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart	View	4 chunks	+10 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/build.dart	View	3 chunks	+4 lines, -4 lines	1 comment	Download
A +	sdk/lib/_internal/pub/test/serve/serves_file_with_space_test.dart	View	1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/312523007/diff/1/sdk/lib/_internal/pub/lib/src/command/build.dart File sdk/lib/_internal/pub/lib/src/command/build.dart (right): https://codereview.chromium.org/312523007/diff/1/sdk/lib/_internal/pub/lib/src/command/build.dart#newcode162 sdk/lib/_internal/pub/lib/src/command/build.dart:162: String _idToPath(AssetId id) { Ugh, how did this ...

6 years, 6 months ago (2014-06-02 22:49:49 UTC) #2

nweiz

6 years, 6 months ago (2014-06-02 23:18:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36906 (presubmit successful).

Expand Messages | Collapse Messages