Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 312163003: Fix yaml's SDK constraint to contain only SDKs with MapMixin. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix yaml's SDK constraint to contain only SDKs with MapMixin. R=rnystrom@google.com BUG=19200 Committed: https://code.google.com/p/dart/source/detail?r=37024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/yaml/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 6 months ago (2014-06-04 19:26:53 UTC) #1
Bob Nystrom
That's a really narrow constraint. :( LGTM.
6 years, 6 months ago (2014-06-05 00:43:39 UTC) #2
nweiz
Committed patchset #1 manually as r37024 (presubmit successful).
6 years, 6 months ago (2014-06-05 00:47:32 UTC) #3
nweiz
6 years, 6 months ago (2014-06-05 00:54:41 UTC) #4
Message was sent while issue was closed.
On 2014/06/05 00:43:39, Bob Nystrom wrote:
> That's a really narrow constraint. :(
> 
> LGTM.

Luckily, all the packages in the wild that can use yaml 1.0.0 can also use older
versions with more narrow constraints.

Powered by Google App Engine
This is Rietveld 408576698