Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 312123002: Revert "Ensure that failure to start an isolate all end up in the future." (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Ensure that failure to start an isolate all end up in the future." Committed: https://code.google.com/p/dart/source/detail?r=36986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -284 lines) Patch
M runtime/lib/isolate_patch.dart View 2 chunks +8 lines, -26 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +7 lines, -17 lines 0 comments Download
M tests/isolate/isolate.status View 2 chunks +0 lines, -6 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_echo.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_lib.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_lib2.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_lib3.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_lib4.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_lib5.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/isolate/isolate_create_error_helper_syntax_error.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/isolate/isolate_create_error_test.dart View 1 chunk +0 lines, -161 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
Bots fail that doesn't reproduce locally. Have to investigate. TBR.
6 years, 6 months ago (2014-06-04 09:40:19 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r36986 (presubmit successful).
6 years, 6 months ago (2014-06-04 09:40:38 UTC) #2
Søren Gjesse
6 years, 6 months ago (2014-06-04 10:30:43 UTC) #3
Message was sent while issue was closed.
lgtm :-(

Powered by Google App Engine
This is Rietveld 408576698