Issue 311963002: In class Function replace current code field with current instruction field, that way we save one l…

Issue 311963002: In class Function replace current code field with current instruction field, that way we save one l… (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

In class Function replace current code field with current instruction field, that way we save one load when jumping to a target in, e.g., inline cache stub (function->instruction vs function->code->instruction). R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=36948

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -83 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/gc_marker.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	4 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		4 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		4 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	4 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		4 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		4 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/311963002/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/311963002/diff/20001/runtime/vm/object.cc#newcode6307 runtime/vm/object.cc:6307: Code::Handle(Instructions::Handle(raw_ptr()->instructions_).code()). I haven't seen many line breaks after ...

6 years, 6 months ago (2014-06-03 21:05:23 UTC) #2

srdjan

Committed patchset #3 manually as r36948 (presubmit successful).

6 years, 6 months ago (2014-06-03 21:28:13 UTC) #3

srdjan

6 years, 6 months ago (2014-06-03 21:28:34 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/311963002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/311963002/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:6307:
Code::Handle(Instructions::Handle(raw_ptr()->instructions_).code()).
On 2014/06/03 21:05:23, zra wrote:
> I haven't seen many line breaks after . in our code. Maybe break after
> Instructions::Handle( ?

Done.

https://codereview.chromium.org/311963002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/311963002/diff/20001/runtime/vm/object.h#newc...
runtime/vm/object.h:1579: void SetCode(const Code& value) const;
On 2014/06/03 21:05:23, zra wrote:
> maybe SetInstructions?

Done.

Expand Messages | Collapse Messages