Tweaks for typed_mock.

Tweaks for typed_mock.

1. Force dynamic type for 'any*' matchers, now we propagate types of top-level variables and fields, so using these matchers causes hints.

2. Remove equals() matcher, in conflicts with the one from unittest.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36954

[Brian Wilkerson, 2014-06-03 22:10:46]

LGTM, but

> 1. Force dynamic type for 'any*' matchers, now we propagate types of
> top-level variables and fields, so using these matchers causes hints.

I would like to understand what hints are being produced and why they are being
produced, because this sounds like a false-positive, and I don't want false
positives.

[scheglov, 2014-06-03 22:19:52]

On 2014/06/03 22:10:46, Brian Wilkerson wrote:
> LGTM, but
> 
> > 1. Force dynamic type for 'any*' matchers, now we propagate types of
> > top-level variables and fields, so using these matchers causes hints.
> 
> I would like to understand what hints are being produced and why they are
being
> produced, because this sounds like a false-positive, and I don't want false
> positives.


class Matcher {
}
final anyString = new Matcher();
f(String s) {
}
main() {
  f(anyString);
}

It causes the following hint: The argument type 'Matcher
(/Users/scheglov/dart/test/bin/test.dart)' cannot be assigned to the parameter
type 'String
(/Users/scheglov/Source/Dart/eclipse_382-wst/dart-sdk/lib/core/string.dart)'

Static type of anyString is dynamic, and propagated type is Matcher.

[scheglov, 2014-06-03 22:21:25]

Committed patchset #1 manually as r36954 (presubmit successful).

[kevmoo, 2014-06-03 23:50:10]

DBQ

https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
File pkg/typed_mock/lib/typed_mock.dart (right):

https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
pkg/typed_mock/lib/typed_mock.dart:392: final anyBool = new
_ArgumentMatcher_anyBool() as dynamic;
Doesn't typing the final as 'dynamic' accomplish the same thing...perhaps a bit
prettier.

Also: could these all be const?

[scheglov, 2014-06-04 00:36:50]

On 2014/06/03 23:50:10, kevmoo wrote:
> DBQ
> 
>
https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
> File pkg/typed_mock/lib/typed_mock.dart (right):
> 
>
https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
> pkg/typed_mock/lib/typed_mock.dart:392: final anyBool = new
> _ArgumentMatcher_anyBool() as dynamic;
> Doesn't typing the final as 'dynamic' accomplish the same thing...perhaps a
bit
> prettier.
> 
> Also: could these all be const?

Unfortunately no.
Currently we don't distinguish "var" (or "final" without any type annotation)
and explicit "dynamic" type annotation when do type propagation.
So, we have to force dynamic type using type cast.

And, because a type cast expression is not a constant, we cannot declare these
"any*" top-level variables as constants.

[kevmoo, 2014-06-04 05:00:09]

On 2014/06/04 00:36:50, scheglov wrote:
> On 2014/06/03 23:50:10, kevmoo wrote:
> > DBQ
> > 
> >
>
https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
> > File pkg/typed_mock/lib/typed_mock.dart (right):
> > 
> >
>
https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
> > pkg/typed_mock/lib/typed_mock.dart:392: final anyBool = new
> > _ArgumentMatcher_anyBool() as dynamic;
> > Doesn't typing the final as 'dynamic' accomplish the same thing...perhaps a
> bit
> > prettier.
> > 
> > Also: could these all be const?
> 
> Unfortunately no.
> Currently we don't distinguish "var" (or "final" without any type annotation)
> and explicit "dynamic" type annotation when do type propagation.
> So, we have to force dynamic type using type cast.
> 
> And, because a type cast expression is not a constant, we cannot declare these
> "any*" top-level variables as constants.

That's unfortunate, but understandable.

You could have const classes and instantiation, right?

final anyBool = const _ArgumentMatcher_anyBool() as dynamic;

[scheglov, 2014-06-04 14:38:58]

On 2014/06/04 05:00:09, kevmoo wrote:
> On 2014/06/04 00:36:50, scheglov wrote:
> > On 2014/06/03 23:50:10, kevmoo wrote:
> > > DBQ
> > > 
> > >
> >
>
https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
> > > File pkg/typed_mock/lib/typed_mock.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/311893002/diff/1/pkg/typed_mock/lib/typed_moc...
> > > pkg/typed_mock/lib/typed_mock.dart:392: final anyBool = new
> > > _ArgumentMatcher_anyBool() as dynamic;
> > > Doesn't typing the final as 'dynamic' accomplish the same thing...perhaps
a
> > bit
> > > prettier.
> > > 
> > > Also: could these all be const?
> > 
> > Unfortunately no.
> > Currently we don't distinguish "var" (or "final" without any type
annotation)
> > and explicit "dynamic" type annotation when do type propagation.
> > So, we have to force dynamic type using type cast.
> > 
> > And, because a type cast expression is not a constant, we cannot declare
these
> > "any*" top-level variables as constants.
> 
> That's unfortunate, but understandable.
> 
> You could have const classes and instantiation, right?
> 
> final anyBool = const _ArgumentMatcher_anyBool() as dynamic;

Yes, that's possible.
https://codereview.chromium.org/318683003