Extract analysis/notifications into a separate operation/file.

Extract analysis/notifications into a separate operation/file.

It seems that while we really have to expose some additional API from AnalysisServer,
it still worth to extract analysis and its notifications into a separate file.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36899

[Paul Berry, 2014-06-02 20:07:34]

lgtm

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/test...
File pkg/analysis_server/test/reflective_tests.dart (right):

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/reflective_tests.dart:40: void runReflectiveTests(Type
type) {
I thought we decided that we were going to move away from the Java-style
reflective tests and follow the recommendations of
https://www.dartlang.org/articles/dart-unit-tests/.  Was there further
discussion about this that I missed?

[Brian Wilkerson, 2014-06-02 20:12:58]

The extraction LGTM. Not as fond of the top-level functions and extra test
framework.

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right):

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/operation/operation_analysis.dart:83: void
sendAnalysisNotificationErrors(AnalysisServer server,
Have I ever told you how much I dislike top-level functions :-)

How about
  server.sendAnalysisNotificationErrors(file, notice.errors);

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/test...
File pkg/analysis_server/test/reflective_tests.dart (right):

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/reflective_tests.dart:5: library reflective.tests;
Do we really need another test framework? I'm not sure I understand what this
one buys us.

[scheglov, 2014-06-02 20:38:09]

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right):

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/operation/operation_analysis.dart:83: void
sendAnalysisNotificationErrors(AnalysisServer server,
On 2014/06/02 20:12:58, Brian Wilkerson wrote:
> Have I ever told you how much I dislike top-level functions :-)

Yes, you have :-)


> 
> How about
>   server.sendAnalysisNotificationErrors(file, notice.errors);

Problem is that these functions not quite belong to the server.
They are part of analysis, so ideally I'd like to keep them in the
PerformAnalysisOperation.
But OTOH they are also used by server when subscriptions are changed.
Given that we decided to try to pull analysis out of server, moving these into
top-level function seemed like a possible solution to me.

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/test...
File pkg/analysis_server/test/reflective_tests.dart (right):

https://codereview.chromium.org/311653002/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/reflective_tests.dart:40: void runReflectiveTests(Type
type) {
On 2014/06/02 20:07:34, Paul Berry wrote:
> I thought we decided that we were going to move away from the Java-style
> reflective tests and follow the recommendations of
> https://www.dartlang.org/articles/dart-unit-tests/.  Was there further
> discussion about this that I missed?

I have been trying different approaches to write tests for
notification.navigation and with helper code looks like shit.
With all these constant repetitions of helper. helper. helper. everywhere.
Also I cannot navigate in these tests.
And I'd like to sort them automatically, which is more-less doable to methods,
but not so easy for test()/group() invocations.


We still use unit-test package, but with a layer on top of it.

[scheglov, 2014-06-02 21:00:57]

Committed patchset #2 manually as r36899 (presubmit successful).