Issue 311513002: Enable throttleing of HttpClient per host, with default being 6.

Issue 311513002: Enable throttleing of HttpClient per host, with default being 6. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen

Modified:
6 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable throttleing of HttpClient per host, with default being 6. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36861

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -2 lines)			Patch
M	sdk/lib/io/http.dart	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1 2 3	8 chunks	+26 lines, -2 lines	0 comments	Download
M	sdk/lib/io/io.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_client_connect_test.dart	View	1 2	2 chunks	+33 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_response_deadline_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/http_shutdown_test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Looks good, but we should have a test for this. Maybe a server that checks ...

6 years, 6 months ago (2014-06-02 07:43:04 UTC) #2

Søren Gjesse

lgtm https://codereview.chromium.org/311513002/diff/30001/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/311513002/diff/30001/sdk/lib/io/http.dart#newcode1235 sdk/lib/io/http.dart:1235: * Default is 6. Make the default `null` ...

6 years, 6 months ago (2014-06-02 10:33:20 UTC) #4

Anders Johnsen

Committed patchset #4 manually as r36861 (presubmit successful).

6 years, 6 months ago (2014-06-02 10:38:12 UTC) #5

Anders Johnsen

6 years, 6 months ago (2014-06-02 10:38:46 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/311513002/diff/30001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/311513002/diff/30001/sdk/lib/io/http.dart#new...
sdk/lib/io/http.dart:1235: * Default is 6.
On 2014/06/02 10:33:20, Søren Gjesse wrote:
> Make the default `null` to keep the existing behavior unless you ask for
> something else.

I was under the assumption we wanted to provide a 'nice behaving' default
behavior, but I've disabled it by default.

Come to think of it, if it's not default, we might as well have put it into a
package.

Expand Messages | Collapse Messages