Issue 311403003: Fix bug in code_transformers. Apparently mock SDK needs to have a source factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 311403003: Fix bug in code_transformers. Apparently mock SDK needs to have a source factory (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 6 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug in code_transformers. Apparently mock SDK needs to have a source factory too. I only run into this in some external projects, I'm not sure yet how to create a small repro/test for it, though. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=37044

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	pkg/code_transformers/lib/src/dart_sdk.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/code_transformers/lib/src/resolvers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/code_transformers/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

6 years, 6 months ago (2014-06-05 18:23:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37044 (presubmit successful).

Expand Messages | Collapse Messages