Add an http_multi_server package.

Add an http_multi_server package.

This package supports using the same server class for multiple bound interfaces.
In particular, it's useful for binding both IPv4 and IPv6 loopback interfaces.

R=rnystrom@google.com
BUG=19147
Committed: https://code.google.com/p/dart/source/detail?r=37023

[Bob Nystrom, 2014-06-04 23:58:17]

Is src/http_multi_server.dart supposed to exist or be empty?

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/lib/ht...
File pkg/http_multi_server/lib/http_multi_server.dart (right):

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/lib/ht...
pkg/http_multi_server/lib/http_multi_server.dart:66: /// If this computer
supports both IPv4 and IPv6, this will return an
"will return" -> "returns", and below.

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/lib/ht...
pkg/http_multi_server/lib/http_multi_server.dart:123: HttpConnectionsInfo
connectionsInfo() {
Document this since it has interesting semantics.

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
File pkg/http_multi_server/test/http_multi_server_test.dart (right):

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
pkg/http_multi_server/test/http_multi_server_test.dart:26: }),
You could just do:

.then((server) => subServer1 = server)

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
pkg/http_multi_server/test/http_multi_server_test.dart:86: // Queue up some
requests, then wait to make sure they're
Don't leave me hanging!

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
pkg/http_multi_server/test/http_multi_server_test.dart:119: return
supportsIpV6.then((supportsIpV6) {
I'm iffy about this check. It's possible for us to have no IPv6 coverage and not
know it if none of the bots happen to support it. (Especially since many of the
issues this package solves have only appeared on the bots.) How about making a
separate IPv6 test and then use status files to control which bots it runs on?

[nweiz, 2014-06-05 00:36:09]

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/lib/ht...
File pkg/http_multi_server/lib/http_multi_server.dart (right):

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/lib/ht...
pkg/http_multi_server/lib/http_multi_server.dart:66: /// If this computer
supports both IPv4 and IPv6, this will return an
On 2014/06/04 23:58:17, Bob Nystrom wrote:
> "will return" -> "returns", and below.

Done.

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/lib/ht...
pkg/http_multi_server/lib/http_multi_server.dart:123: HttpConnectionsInfo
connectionsInfo() {
On 2014/06/04 23:58:17, Bob Nystrom wrote:
> Document this since it has interesting semantics.

Done.

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
File pkg/http_multi_server/test/http_multi_server_test.dart (right):

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
pkg/http_multi_server/test/http_multi_server_test.dart:26: }),
On 2014/06/04 23:58:17, Bob Nystrom wrote:
> You could just do:
> 
> .then((server) => subServer1 = server)

Done.

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
pkg/http_multi_server/test/http_multi_server_test.dart:86: // Queue up some
requests, then wait to make sure they're
On 2014/06/04 23:58:17, Bob Nystrom wrote:
> Don't leave me hanging!

Done.

https://codereview.chromium.org/311233004/diff/1/pkg/http_multi_server/test/h...
pkg/http_multi_server/test/http_multi_server_test.dart:119: return
supportsIpV6.then((supportsIpV6) {
On 2014/06/04 23:58:17, Bob Nystrom wrote:
> I'm iffy about this check. It's possible for us to have no IPv6 coverage and
not
> know it if none of the bots happen to support it. (Especially since many of
the
> issues this package solves have only appeared on the bots.) How about making a
> separate IPv6 test and then use status files to control which bots it runs on?

I really don't want to be in the business of maintaining a list of which bots do
and don't support IPv6. In practice I'm sure almost all of them do and will
continue to indefinitely; we've already seen that a number of bots do support it
by seeing the errors that this is working around.

[Bob Nystrom, 2014-06-05 00:39:28]

lgtm

[nweiz, 2014-06-05 00:43:44]

Committed patchset #2 manually as r37023 (presubmit successful).