Issue 311153003: Add Observatory test of io.

Issue 311153003: Add Observatory test of io. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen

Modified:
6 years, 6 months ago

Reviewers:
Søren Gjesse, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add Observatory test of io. Initially a single test of a HttpServer. More will follow. This also fixes the case where we don't 'block' when binding to a ServerSocket. We should not close until the socket is explicitly closed. BUG= R=johnmccutchan@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37164

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -5 lines)			Patch
M	runtime/bin/service_object_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View		4 chunks	+6 lines, -2 lines	0 comments	Download
A	tests/standalone/io/observatory.dart	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
M	tests/standalone/io/raw_socket_test.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/io/socket_exception_test.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	tests/standalone/io/socket_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/311153003/diff/1/tests/standalone/io/observatory.dart File tests/standalone/io/observatory.dart (right): https://codereview.chromium.org/311153003/diff/1/tests/standalone/io/observatory.dart#newcode5 tests/standalone/io/observatory.dart:5: // SharedOptions=-Da=true -Db=false -Dc=NOTBOOL -Dd=True Whar are these ...

6 years, 6 months ago (2014-06-10 07:00:37 UTC) #3

Anders Johnsen

https://codereview.chromium.org/311153003/diff/1/tests/standalone/io/observatory.dart File tests/standalone/io/observatory.dart (right): https://codereview.chromium.org/311153003/diff/1/tests/standalone/io/observatory.dart#newcode5 tests/standalone/io/observatory.dart:5: // SharedOptions=-Da=true -Db=false -Dc=NOTBOOL -Dd=True On 2014/06/10 07:00:37, Søren ...

6 years, 6 months ago (2014-06-10 07:13:21 UTC) #4

Anders Johnsen

6 years, 6 months ago (2014-06-10 07:14:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r37164 (presubmit successful).

Expand Messages | Collapse Messages