Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 311053005: Updates for the Outline API and use it in Editor. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1, lukeechurch_gmail.com
Visibility:
Public.

Description

Updates for the Outline API and use it in Editor. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -183 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/Outline.java View 3 chunks +31 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java View 4 chunks +20 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/OutlineImpl.java View 6 chunks +59 lines, -39 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisOutlineProcessor.java View 2 chunks +14 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/local/computer/OutlineImplTest.java View 2 chunks +40 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 3 chunks +19 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 2 chunks +17 lines, -35 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartOutlinePage_NEW.java View 7 chunks +100 lines, -20 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 4 chunks +15 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 30 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-06-05 02:46:26 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-05 13:46:55 UTC) #2
scheglov
6 years, 6 months ago (2014-06-05 17:01:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698