Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 31043004: Fixes the deploy step used by the bots in windows (Closed)

Created:
7 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes the deploy step used by the bots in windows R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29027

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -24 lines) Patch
M pkg/pkg.status View 1 chunk +10 lines, -10 lines 0 comments Download
M pkg/polymer/lib/deploy.dart View 3 chunks +15 lines, -11 lines 1 comment Download
M pkg/polymer/lib/src/build/common.dart View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-22 18:55:41 UTC) #1
Siggi Cherem (dart-lang)
https://codereview.chromium.org/31043004/diff/40001/pkg/polymer/lib/deploy.dart File pkg/polymer/lib/deploy.dart (left): https://codereview.chromium.org/31043004/diff/40001/pkg/polymer/lib/deploy.dart#oldcode74 pkg/polymer/lib/deploy.dart:74: transformOps.entryPoints = [path.relative(testFile, from: pubspecDir)]; I didn't realize this ...
7 years, 2 months ago (2013-10-22 18:57:58 UTC) #2
Jennifer Messerly
awesome! lgtm
7 years, 2 months ago (2013-10-22 19:01:23 UTC) #3
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-22 19:32:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698