Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 310363002: Fix dart analyzer warnings. (Closed)

Created:
6 years, 6 months ago by Jacob
Modified:
6 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix dart analyzer warnings. Ignore static mirrors without valid names. BUG= Committed: https://code.google.com/p/dart/source/detail?r=36977

Patch Set 1 #

Patch Set 2 : Fix errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tools/dom/src/html_native_DOMImplementation.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
TBR
6 years, 6 months ago (2014-06-04 05:45:40 UTC) #1
Jacob
Committed patchset #2 manually as r36977.
6 years, 6 months ago (2014-06-04 05:46:01 UTC) #2
vsm
6 years, 6 months ago (2014-06-04 06:45:32 UTC) #3
Message was sent while issue was closed.
lgtm - what warnings were you seeing?

Powered by Google App Engine
This is Rietveld 408576698