Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 310053004: Add an exitOnClose function to the "pub serve" WebSocket API. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an exitOnClose function to the "pub serve" WebSocket API. This function takes no parameters and causes "pub serve" to exit as soon as the WebSocket connection is closed. R=rnystrom@google.com BUG=19086 Committed: https://code.google.com/p/dart/source/detail?r=36944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart View 3 chunks +17 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/utils.dart View 2 chunks +18 lines, -8 lines 0 comments Download
A sdk/lib/_internal/pub/test/serve/web_socket/exit_on_close_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 6 months ago (2014-06-03 20:24:40 UTC) #1
Bob Nystrom
lgtm
6 years, 6 months ago (2014-06-03 20:30:17 UTC) #2
nweiz
6 years, 6 months ago (2014-06-03 21:09:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698