Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 308923003: Initial implementation for 'analysis.setSubscriptions' API. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial implementation for 'analysis.setSubscriptions' API. Not quite all, and not as operations yet. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -34 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +58 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +17 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 2 chunks +43 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 7 chunks +80 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-05-30 20:57:43 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-05-30 21:01:21 UTC) #2
scheglov
6 years, 6 months ago (2014-05-30 21:02:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36834 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698