When a connection is upgraded, don't return it as idle.

When a connection is upgraded, don't return it as idle.

Instead we now simply close the socket and return a 'done' stream
subscription, if the user listened to the response. The only way to get
data from a 'upgraded' response, is now by actually doing a detach.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36858

[Søren Gjesse, 2014-06-02 07:30:52]

lgtm

https://codereview.chromium.org/308923002/diff/1/tests/standalone/io/http_det...
File tests/standalone/io/http_detach_socket_test.dart (right):

https://codereview.chromium.org/308923002/diff/1/tests/standalone/io/http_det...
tests/standalone/io/http_detach_socket_test.dart:151:
request.response.headers.set('connection', 'upgrade');
Should this test also detach the socket on this side, and maybe send some data?

[Anders Johnsen, 2014-06-02 08:00:34]

https://codereview.chromium.org/308923002/diff/1/tests/standalone/io/http_det...
File tests/standalone/io/http_detach_socket_test.dart (right):

https://codereview.chromium.org/308923002/diff/1/tests/standalone/io/http_det...
tests/standalone/io/http_detach_socket_test.dart:151:
request.response.headers.set('connection', 'upgrade');
On 2014/06/02 07:30:52, Søren Gjesse wrote:
> Should this test also detach the socket on this side, and maybe send some
data?

Done.

[Søren Gjesse, 2014-06-02 08:16:27]

lgtm

[Anders Johnsen, 2014-06-02 08:17:44]

Committed patchset #3 manually as r36858 (presubmit successful).