Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 308773003: Found some more code referring to the special "asset" directory. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Found some more code referring to the special "asset" directory. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=36826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -128 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart View 2 chunks +6 lines, -11 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/barback.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/barback/fails_on_disallowed_directories_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D sdk/lib/_internal/pub/test/dart2js/ignores_entrypoints_in_lib_and_asset_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
A + sdk/lib/_internal/pub/test/dart2js/ignores_entrypoints_in_lib_test.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/missing_asset_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/missing_dependency_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/missing_file_test.dart View 3 chunks +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_errors_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_test.dart View 4 chunks +1 line, -34 lines 0 comments Download
M sdk/lib/_internal/pub/test/transformer/does_not_run_a_transform_on_an_input_in_another_package_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
6 years, 6 months ago (2014-05-29 21:23:26 UTC) #1
nweiz
lgtm
6 years, 6 months ago (2014-05-29 21:44:35 UTC) #2
Bob Nystrom
6 years, 6 months ago (2014-05-30 17:44:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698