Use SpanScanner to emit better YAML parse errors.

Use SpanScanner to emit better YAML parse errors.

R=efortuna@google.com, jmesserly@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36897

[nweiz, 2014-05-30 01:18:29]

+efortuna, +jmesserly for pubspec changes for real this time

[Jennifer Messerly, 2014-05-30 01:22:59]

polymer change lgtm. thank you! more dependency range == goodness :)

[Emily Fortuna, 2014-05-30 16:24:15]

docgen change lgtm

[Bob Nystrom, 2014-05-30 16:32:39]

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
File pkg/yaml/lib/src/parser.dart (right):

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
pkg/yaml/lib/src/parser.dart:158: /// Return the character at the current
position, then move that position
"Return" -> "Returns"
"move" -> "moves"

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
pkg/yaml/lib/src/parser.dart:371: /// [_farthestColumn], and [_farthestContext]
to provide additional
Update this.

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
pkg/yaml/lib/src/parser.dart:650: return result;
Why this change?

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/yaml.dart
File pkg/yaml/lib/yaml.dart (right):

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/yaml.dart#n...
pkg/yaml/lib/yaml.dart:30: /// It's used for error reporting.
I think it would be good to explicitly mention that it's optional.

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/yaml.dart#n...
pkg/yaml/lib/yaml.dart:51: /// It's used for error reporting.
Here too.

[nweiz, 2014-06-02 18:36:13]

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
File pkg/yaml/lib/src/parser.dart (right):

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
pkg/yaml/lib/src/parser.dart:158: /// Return the character at the current
position, then move that position
On 2014/05/30 16:32:39, Bob Nystrom wrote:
> "Return" -> "Returns"
> "move" -> "moves"

Done.

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
pkg/yaml/lib/src/parser.dart:371: /// [_farthestColumn], and [_farthestContext]
to provide additional
On 2014/05/30 16:32:39, Bob Nystrom wrote:
> Update this.

Done.

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/src/parser....
pkg/yaml/lib/src/parser.dart:650: return result;
On 2014/05/30 16:32:39, Bob Nystrom wrote:
> Why this change?

Leftover from debugging, undone.

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/yaml.dart
File pkg/yaml/lib/yaml.dart (right):

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/yaml.dart#n...
pkg/yaml/lib/yaml.dart:30: /// It's used for error reporting.
On 2014/05/30 16:32:39, Bob Nystrom wrote:
> I think it would be good to explicitly mention that it's optional.

Done.

https://codereview.chromium.org/308743007/diff/20001/pkg/yaml/lib/yaml.dart#n...
pkg/yaml/lib/yaml.dart:51: /// It's used for error reporting.
On 2014/05/30 16:32:39, Bob Nystrom wrote:
> Here too.

Done.

[Bob Nystrom, 2014-06-02 19:35:12]

lgtm

[nweiz, 2014-06-02 20:31:41]

Committed patchset #3 manually as r36897 (presubmit successful).