Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 308653004: Fix analyzer hints in pkg/collection. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix analyzer hints in pkg/collection. I plan to release collection 0.9.3+1 once this lands. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=36814

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M pkg/collection/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/collection/lib/src/unmodifiable_wrappers.dart View 1 9 chunks +11 lines, -15 lines 0 comments Download
M pkg/collection/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 6 months ago (2014-05-29 21:52:17 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/308653004/diff/1/pkg/collection/lib/src/unmodifiable_wrappers.dart File pkg/collection/lib/src/unmodifiable_wrappers.dart (right): https://codereview.chromium.org/308653004/diff/1/pkg/collection/lib/src/unmodifiable_wrappers.dart#newcode56 pkg/collection/lib/src/unmodifiable_wrappers.dart:56: throw 'unreachable'; Maybe change _throw to return dynamic ...
6 years, 6 months ago (2014-05-29 21:55:05 UTC) #2
nweiz
https://codereview.chromium.org/308653004/diff/1/pkg/collection/lib/src/unmodifiable_wrappers.dart File pkg/collection/lib/src/unmodifiable_wrappers.dart (right): https://codereview.chromium.org/308653004/diff/1/pkg/collection/lib/src/unmodifiable_wrappers.dart#newcode56 pkg/collection/lib/src/unmodifiable_wrappers.dart:56: throw 'unreachable'; On 2014/05/29 21:55:06, Lasse Reichstein Nielsen wrote: ...
6 years, 6 months ago (2014-05-30 00:49:41 UTC) #3
nweiz
6 years, 6 months ago (2014-05-30 00:50:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698