Issue 308513005: Intrinsify [] for ExternalUint8 and Uint8 typed data.

Issue 308513005: Intrinsify [] for ExternalUint8 and Uint8 typed data. (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Intrinsify [] for ExternalUint8 and Uint8 typed data. Gives significant speedup when compiling Hello.dart in unoptimized code. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=36833

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -12 lines)			Patch
M	runtime/lib/object.cc	View	1 2 3	3 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 2 3	3 chunks	+46 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	1 2 3	3 chunks	+48 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 2 3	3 chunks	+49 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
M	tests/standalone/typed_data_test.dart	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/308513005/diff/40001/runtime/vm/intrinsifier_arm64.cc File runtime/vm/intrinsifier_arm64.cc (right): https://codereview.chromium.org/308513005/diff/40001/runtime/vm/intrinsifier_arm64.cc#newcode370 runtime/vm/intrinsifier_arm64.cc:370: // Untag R0; ; -> . https://codereview.chromium.org/308513005/diff/40001/runtime/vm/intrinsifier_arm64.cc#newcode394 runtime/vm/intrinsifier_arm64.cc:394: ...

6 years, 6 months ago (2014-05-30 18:10:59 UTC) #2

srdjan

https://codereview.chromium.org/308513005/diff/40001/runtime/vm/intrinsifier_arm64.cc File runtime/vm/intrinsifier_arm64.cc (right): https://codereview.chromium.org/308513005/diff/40001/runtime/vm/intrinsifier_arm64.cc#newcode370 runtime/vm/intrinsifier_arm64.cc:370: // Untag R0; On 2014/05/30 18:11:00, zra wrote: > ...

6 years, 6 months ago (2014-05-30 19:23:12 UTC) #3

srdjan

6 years, 6 months ago (2014-05-30 19:49:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r36833 (presubmit successful).

Expand Messages | Collapse Messages