Issue 308283003: Fix crash when a closure self-referenced in a try.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308283003: Fix crash when a closure self-referenced in a try. (Closed)

Created:
6 years, 6 months ago by floitsch

Modified:
6 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix crash when a closure self-referenced in a try. In host-checked mode dart2js would crash when a nested function would reference itself again inside a try/catch. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37488

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/closure.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	A	tests/language/closure_self_reference_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

floitsch

6 years, 6 months ago (2014-06-19 12:12:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37488 (presubmit successful).