Issue 308053012: Fix try-catch and continue in switch statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308053012: Fix try-catch and continue in switch statements. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
srdjan, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix try-catch and continue in switch statements. When assigning the try-index for continue targets, use the try index of the enclosing nested statement, not the current try-index of the graph builder. BUG=dartbug.com/18869 TEST=tests/language/switch_try_catch_test.dart R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36876

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -3 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		4 chunks	+7 lines, -3 lines	2 comments	Download
	A	tests/language/switch_try_catch_test.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #1 manually as r36876 (presubmit successful).

6 years, 6 months ago (2014-06-02 15:46:43 UTC) #3

srdjan

DBC https://codereview.chromium.org/308053012/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/308053012/diff/1/runtime/vm/flow_graph_builder.cc#newcode112 runtime/vm/flow_graph_builder.cc:112: intptr_t try_index_; const?

6 years, 6 months ago (2014-06-02 18:29:31 UTC) #4

Florian Schneider

6 years, 6 months ago (2014-06-03 10:50:18 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/308053012/diff/1/runtime/vm/flow_graph_builde...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/308053012/diff/1/runtime/vm/flow_graph_builde...
runtime/vm/flow_graph_builder.cc:112: intptr_t try_index_;
On 2014/06/02 18:29:31, srdjan wrote:
> const?

Yes, I will add it in my next cl.

Expand Messages | Collapse Messages