Issue 307963006: Implementation of 'notification.highlight' API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307963006: Implementation of 'notification.highlight' API. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implementation of 'notification.highlight' API. Still no subscriptions yet, so we generate highlight regions for all non-SDK files. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36822

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1323 lines, -35 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	2 chunks	+19 lines, -6 lines	0 comments	Download
A	pkg/analysis_server/lib/src/computers.dart	View	1 chunk	+511 lines, -0 lines	1 comment	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	10 chunks	+793 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/307963006/diff/1/pkg/analysis_server/lib/src/computers.dart File pkg/analysis_server/lib/src/computers.dart (right): https://codereview.chromium.org/307963006/diff/1/pkg/analysis_server/lib/src/computers.dart#newcode296 pkg/analysis_server/lib/src/computers.dart:296: class DartUnitHighlightsComputerVisitor extends RecursiveAstVisitor<Object> { Perhaps a blank ...

6 years, 6 months ago (2014-05-30 13:58:05 UTC) #2

scheglov

6 years, 6 months ago (2014-05-30 17:22:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36822 (presubmit successful).

Expand Messages | Collapse Messages