Issue 307963004: pkg/mime: Removed mutable state from MimeMultipartTransformer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307963004: pkg/mime: Removed mutable state from MimeMultipartTransformer (Closed)

Created:
6 years, 6 months ago by kevmoo

Modified:
6 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

pkg/mime: Removed mutable state from MimeMultipartTransformer R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=36825

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+434 lines, -392 lines)			Patch
M	pkg/mime/lib/mime.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/mime/lib/src/bound_multipart_stream.dart	View	1 chunk	+375 lines, -0 lines	0 comments	Download
A	pkg/mime/lib/src/char_code.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	pkg/mime/lib/src/mime_multipart_transformer.dart	View	2 chunks	+18 lines, -390 lines	0 comments	Download
A	pkg/mime/lib/src/mime_shared.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	pkg/mime/pubspec.yaml	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

kevmoo

I noticed that MimeMultipartTransformer kept state internally after a call to bind. It's good to ...

6 years, 6 months ago (2014-05-29 22:44:58 UTC) #1

kevmoo

6 years, 6 months ago (2014-05-30 17:39:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36825 (presubmit successful).