Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 307543006: Add a "message" field to wrapped barback exceptions. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a "message" field to wrapped barback exceptions. This makes it possible for calling code to get the error message without the stack trace, if it so desires. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=36724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M pkg/barback/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/errors.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/barback/lib/src/serialize.dart View 1 chunk +1 line, -12 lines 0 comments Download
M pkg/barback/lib/src/utils.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 6 months ago (2014-05-27 22:41:17 UTC) #1
Bob Nystrom
lgtm
6 years, 6 months ago (2014-05-28 00:14:25 UTC) #2
nweiz
6 years, 6 months ago (2014-05-28 00:43:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698