Send 'notification.errors' for all non-SDK files.

Send 'notification.errors' for all non-SDK files.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36743

[Brian Wilkerson, 2014-05-28 14:25:21]

LGTM

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:87: DartSdk defaultSdk =
SHARED_SDK;
For discussion: I'm not sure this is the behavior we want. It seems to me that
the client should be required to set the default SDK and that server should
return an error if there is no default when it tries to create a context.

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:340: 'file':
analysisError.source.fullName,
These strings should be constants.

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_analysis_test.dart (right):

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_analysis_test.dart:115:
testNotificationErrors();
Why are these tests in a separate method? And if they stay that way, why not

group('...', testNotificationErrors);

[scheglov, 2014-05-28 15:46:37]

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:87: DartSdk defaultSdk =
SHARED_SDK;
On 2014/05/28 14:25:21, Brian Wilkerson wrote:
> For discussion: I'm not sure this is the behavior we want. It seems to me that
> the client should be required to set the default SDK and that server should
> return an error if there is no default when it tries to create a context.

I agree.
This API is just not implemented yet.

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:340: 'file':
analysisError.source.fullName,
On 2014/05/28 14:25:21, Brian Wilkerson wrote:
> These strings should be constants.

Will extract them in a separate CL.

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_analysis_test.dart (right):

https://codereview.chromium.org/307533004/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_analysis_test.dart:115:
testNotificationErrors();
On 2014/05/28 14:25:21, Brian Wilkerson wrote:
> Why are these tests in a separate method? And if they stay that way, why not

I want to start structuring tests.
It seems that different kinds of analysis domain methods may be quite different
from each other.
We decided to use unittest group/test functions plus helpers instead of classes,
so I extracted a function.

> group('...', testNotificationErrors);

Done.

[scheglov, 2014-05-28 15:51:16]

Committed patchset #1 manually as r36743 (presubmit successful).