Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 307483004: Another audiocontext_test fix (Closed)

Created:
6 years, 7 months ago by vsm
Modified:
6 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Another audiocontext_test fix The OscillatorNode.type setter no longer throws an exception on an invalid string. It just ignores the value. See: https://codereview.chromium.org/209423006/diff/100001/Source/modules/webaudio/OscillatorNode.idl TBR=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=36670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tests/html/audiocontext_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vsm
6 years, 7 months ago (2014-05-27 12:13:18 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r36670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698