Issue 307483003: Update Dartium status file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307483003: Update Dartium status file (Closed)

Created:
6 years, 7 months ago by ahe

Modified:
6 years, 7 months ago

Reviewers:
vsm, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update Dartium status file Committed: https://code.google.com/p/dart/source/detail?r=36664

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	dart/tests/isolate/isolate.status	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r36664 (presubmit successful).

6 years, 7 months ago (2014-05-27 11:09:13 UTC) #2

vsm

https://codereview.chromium.org/307483003/diff/1/dart/tests/isolate/isolate.status File dart/tests/isolate/isolate.status (right): https://codereview.chromium.org/307483003/diff/1/dart/tests/isolate/isolate.status#newcode86 dart/tests/isolate/isolate.status:86: spawn_uri_missing_test: Skip # Times out. $runtime == drt as ...

6 years, 7 months ago (2014-05-27 13:03:59 UTC) #3

ahe

6 years, 7 months ago (2014-05-27 13:35:05 UTC) #4

Message was sent while issue was closed.

On 2014/05/27 13:03:59, vsm wrote:
>
https://codereview.chromium.org/307483003/diff/1/dart/tests/isolate/isolate.s...
> File dart/tests/isolate/isolate.status (right):
> 
>
https://codereview.chromium.org/307483003/diff/1/dart/tests/isolate/isolate.s...
> dart/tests/isolate/isolate.status:86: spawn_uri_missing_test: Skip # Times
out.
> $runtime == drt
> 
> as well?

Good catch, Vijay.  Fixed in https://codereview.chromium.org/297183009/.

Expand Messages | Collapse Messages