Issue 306993002: smoke: support named argument in annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306993002: smoke: support named argument in annotations (Closed)

Created:
6 years, 6 months ago by Jennifer Messerly

Modified:
6 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

smoke: support named argument in annotations Was super easy since most of the code is already there :) R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=36816

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -6 lines)			Patch
M	pkg/smoke/lib/codegen/recorder.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	pkg/smoke/test/codegen/end_to_end_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/smoke/test/codegen/recorder_test.dart	View	4 chunks	+29 lines, -1 line	0 comments	Download
M	pkg/smoke/test/common.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	pkg/smoke/test/static_test.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jennifer Messerly

6 years, 6 months ago (2014-05-30 01:05:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36816 (presubmit successful).