Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 306773002: Fix a bug where barback transformers would produce stale output. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a bug where barback transformers would produce stale output. For the gory details, see the new test in pkg/barback/test/package_graph/transform/concurrency_test.dart. R=rnystrom@google.com BUG=19038 Committed: https://code.google.com/p/dart/source/detail?r=36780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -18 lines) Patch
M pkg/barback/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/transformer/aggregate_transform.dart View 2 chunks +13 lines, -17 lines 0 comments Download
M pkg/barback/lib/src/utils/cancelable_future.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/package_graph/transform/concurrency_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 6 months ago (2014-05-28 23:07:51 UTC) #1
Bob Nystrom
Oof. LGTM.
6 years, 6 months ago (2014-05-28 23:37:50 UTC) #2
nweiz
6 years, 6 months ago (2014-05-28 23:57:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698